cwd consistency #611
Merged
cwd consistency #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and returns `Option<path>` Previously the function was willing to return an empty path despite it being invalid. With the `current_dir` being required, this won't be the case anymore and will yield logically consistent results in all cases. This forces the caller to deal with the relative path being invalid or crafted to produce some other path, maybe to bypass sanity checks.
Byron
force-pushed
the
cwd-consistency
branch
2 times, most recently
from
ddfdcc1
to
143c417
Compare
…ment and returns `Option<path>` That way it's possible to avoid at least one call of `std::env::current_dir()` per invocation, which also is more consnstent with similar plumbing methods. Furthermore it can signal with `None` if the input directory was invalid.
That way it's more consistent with similar low-level functions and it's possible to avoid multiple calls to `std::env::current_dir()`. Furthermore, the usage of `current_dir()` is made explicit when instantiating a store to allow it to be resued.
Byron
force-pushed
the
cwd-consistency
branch
from
143c417
to
98c2501
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure our usage of the current_dir is somewhat consistent (#607)
With this patch set it's used implicitly only where absolutely required, namely
git-odbin theStoreand in the higher-levelgit-repository.