restrict sha1
asm
to supported archs
#501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only compiles on aarch64, x86 and x86_64 (I also made an upstream PR, but I'm not sure how receptive they will be to that considering they still haven't disabled MSVC). I also switched the cargo files to use the new crate name
sha1
.Ok for Byron review the PR on video?
If I think the review will be helpful for the community, then I might record and publish a video.