Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict sha1 asm to supported archs #501

Merged
merged 1 commit into from
Aug 25, 2022
Merged

restrict sha1 asm to supported archs #501

merged 1 commit into from
Aug 25, 2022

Conversation

davidkna
Copy link
Contributor

It only compiles on aarch64, x86 and x86_64 (I also made an upstream PR, but I'm not sure how receptive they will be to that considering they still haven't disabled MSVC). I also switched the cargo files to use the new crate name sha1.


Ok for Byron review the PR on video?

  • I give my permission to record review and upload on YouTube publicly

If I think the review will be helpful for the community, then I might record and publish a video.

@Byron
Copy link
Owner

Byron commented Aug 25, 2022

Thanks a lot! I did have some trouble with this in onefetch already where it would fail on win-MSVC despite that seemingly being disabled. Thus I hope that this change here actually kicks in.

Do I assume correctly that you validated it? CI here isn't testing ARM32.

The name-change is much appreciated, too, I'd probably have stopped to receive updates because of it.

In any case, I am merging the change now in the hope it helps, please let me know if you need a new release after validating the change is effective. Thanks a lot.

@Byron Byron merged commit b383fab into Byron:main Aug 25, 2022
@davidkna
Copy link
Contributor Author

Do I assume correctly that you validated it? CI here isn't testing ARM32.

I only validated compilation via cross.

@davidkna davidkna deleted the sha1-arm branch August 25, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants