Add config section for mailmap #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These keys are not used at the moment, but will be introduced as part of the work performed under Byron#1125.
Byron
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Thanks a lot for getting the ball rolling on these! I hope these are the last raw usages of configuration keys as well.
When looking at the mailmap code it was clear that it was from earlier times when configuration access was much more 'raw' than it is now - it surely has come a long way already, but also still has some way to go.
This reminds me that trusted_path() and maybe even path() would still have to be overridden (or amended) in some way in order to get automatic path interpolation.
Byron
force-pushed
the
mailmap-config-section
branch
from
e8d5c6b
to
7f65ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with #1125, I noticed that there were no config tree constants for
mailmap.{blob,file}. This PR adds those keys. They will later be put to use ingitoxide/gix/src/repository/mailmap.rs
Line 30 in 58ed530