Skip to content

Commit

Permalink
decide to not implement regex support (yet) (#427)
Browse files Browse the repository at this point in the history
This is something for git-repository anyway, but it seems like
a lot of work for a rarely used feature and a big dependency which
might not ever be faithfully implemented as the regex engines will
probably differ.
  • Loading branch information
Byron committed May 29, 2022
1 parent 4c5570a commit f54ad38
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crate-status.md
Expand Up @@ -416,6 +416,8 @@ See its [README.md](https://github.com/Byron/gitoxide/blob/main/git-lock/README.
* [ ] support for `GIT_CEILING_DIRECTORIES` environment variable
* [ ] handle other non-discovery modes and provide control over environment variable usage required in applications
* [ ] rev-parse
- **unsupported**
* regex
* [x] instantiation
* [x] access to refs and objects
* **traverse**
Expand Down
8 changes: 8 additions & 0 deletions git-revision/tests/spec/parse.rs
Expand Up @@ -105,6 +105,14 @@ mod revision {
assert!(rec.kind.is_none());
assert_eq!(rec.resolve_ref_input.unwrap(), "HEAD");
}

#[test]
#[ignore]
fn refname_with_head_prefix() {
let rec = parse("HEADfake");
assert!(rec.kind.is_none());
assert_eq!(rec.resolve_ref_input.unwrap(), "HEADfake");
}
}

mod range {
Expand Down

0 comments on commit f54ad38

Please sign in to comment.