working progress printing (#470)

Finally, issues due to bugs in prodash.
Byron · Sep 20, 2022 · 67ec2c7 · 67ec2c7
1 parent 0947c70
commit 67ec2c7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -86,7 +86,7 @@ git-repository = { version = "^0.24.0", path = "git-repository", default-feature
 git-transport-for-configuration-only = { package = "git-transport", optional = true, version = "^0.20.0", path = "git-transport" }
 
 clap = { version = "3.2.5", features = ["derive", "cargo"] }
-prodash = { version = "20.1.1", optional = true, default-features = false }
+prodash = { version = "20.2.0", optional = true, default-features = false }
 atty = { version = "0.2.14", optional = true, default-features = false }
 env_logger = { version = "0.9.0", default-features = false }
 crosstermion = { version = "0.10.1", optional = true, default-features = false }

diff --git a/git-features/Cargo.toml b/git-features/Cargo.toml
@@ -115,7 +115,7 @@ crc32fast = { version = "1.2.1", optional = true }
 sha1 = { version = "0.10.0", optional = true }
 
 # progress
-prodash = { version = "20.1.1", optional = true, default-features = false, features = ["unit-bytes", "unit-human"] }
+prodash = { version = "20.2.0", optional = true, default-features = false, features = ["unit-bytes", "unit-human"] }
 
 # pipe
 bytes = { version = "1.0.0", optional = true }

diff --git a/gitoxide-core/src/hours.rs b/gitoxide-core/src/hours.rs
@@ -211,10 +211,11 @@ where
             drop(tx);
             drop(tx_tree_id);
             progress.show_throughput(start);
+            drop(progress);
 
             let _stats_by_commit_idx = match stat_progress {
                 Some(mut progress) => {
-                    progress.init(Some(commit_idx as usize), progress::count("commits"));
+                    progress.set_max(Some(commit_idx as usize));
                     let mut stats = Vec::new();
                     for handle in stat_threads {
                         stats.extend(handle.join().expect("no panic")?);