Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a check for uncomparable empty structs #366

Closed
wants to merge 1 commit into from

Conversation

ybaldus
Copy link

@ybaldus ybaldus commented Aug 20, 2022

@arp242
Copy link
Collaborator

arp242 commented Oct 22, 2022

Thanks; sorry it took me a while before I got around to reviewing this. I merged it via 8bbca55, but for some reason GitHub didn't recognize it 🤔

@ybaldus
Copy link
Author

ybaldus commented Oct 22, 2022

Thank you for merging it. Maybe because this was my first pull request? The tests didn’t run because the action would need a maintainer to accept it. Did you accept it?

@arp242
Copy link
Collaborator

arp242 commented Oct 22, 2022

I think it's because I did:

  • gh pr checkout 366
  • git rebase master
  • (add a second commit with very small fixes)
  • git checkout master
  • git merge empty-structs

Usually git merge will spot that it belongs to a PR and will close it as merged. The problem here (I think) is that the rebase changed the commit hash from 58faf60 to 8bbca55, and it could no longer recognize it as belonging to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants