Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] accordion for gen2 sdks #3290

Merged
merged 29 commits into from
May 29, 2024

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented May 13, 2024

Description

This PR adds accordion widget for gen2 SDKs

Jira
https://builder-io.atlassian.net/browse/ENG-3855

@sidmohanty11 sidmohanty11 requested a review from a team as a code owner May 13, 2024 16:41
@sidmohanty11 sidmohanty11 requested review from mrkoreye and removed request for a team May 13, 2024 16:41
Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 5f7e793

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@builder.io/sdk-qwik Patch
@builder.io/sdk-react Patch
@builder.io/sdk-react-native Patch
@builder.io/sdk-solid Patch
@builder.io/sdk-svelte Patch
@builder.io/sdk-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:53pm
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:53pm
remix-gen2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:53pm
svelte-vite-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:53pm

Copy link

gitguardian bot commented May 13, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9071768 Triggered Generic High Entropy Secret b02cea1 packages/sdks-tests/src/specs/accordion.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented May 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5f7e793. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants