Fix some rpc bugs #406
Closed
Fix some rpc bugs #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC API calls usually are cancelled too early such as
WARN [04-10|05:33:03.071] Served eth_getBlockByNumber conn=127.0.0.1:46600 reqid=1 t=262.386μs err="context canceled"Also when cancelling the context for a call on a HTTP-based client while the call is running, the select in
requestOp.waitmay hit the<-context.Done()case instead of the<-op.respcase. This doesn't happen often -- our cancel test hasn't caught this even though it ran thousands of times on CI since the RPC client was added.This PR makes sure to cancel the root context passed by RPC calls after all the requests are served and fix the rare deadlock when cancelling HTTP call context.
Prerequisites:
References: