Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP-2718 #359

Closed

Conversation

trinhdn2
Copy link
Contributor

@trinhdn2 trinhdn2 commented Jun 21, 2023

This PR attemps to implement EIP-2718, planing the base code structure to implement more transaction types in the future.

These PRs must be merged first:

Checklist:

  • Move Message from types package to core
  • Generalize the types.TxData interface and implement LegacyTx, DynamicFeeTx
  • Implement eip2930Signer, londonSigner to handle new transaction types signing
  • Regen codec/rlp encoder for some structs
  • Implement the BASEFEE opcode and include it to EVM context
  • Modify RPC APIs to adapt new block/transaction formats and 3rd-party tools such as Hardhat, Remix, etc.
  • Fix NewTransactionsByPriceAndNonce to not removing special txs
  • Implement gas cap and eth_call timeout to prevent DoS
  • Decide if we need to keep or drop legacy receipt RLP core: drop legacy receipt types ethereum/go-ethereum#26225 => Should keep the current legacy receipt RLP type for now
  • Make sure that external tools like puppeth doesn't crash with pre and post London configs
  • Test log filter system with breaking changes
  • Backwards compatible tests
  • Make sure other network can map the correct new chain config at start

Refs:

@tungng98 tungng98 deleted the branch BuildOnViction:upgrade-core-develop December 10, 2023 16:51
@tungng98 tungng98 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants