Deleting a column on google spreadsheet messes with the data #13652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
requested review from
samwho and
mike12345567
and removed request for
a team
adrinr
commented
May 9, 2024
| expect(sheet.setHeaderRow).toHaveBeenCalledWith(["name"]) | ||
|
|
||
| // No undefined are sent | ||
| expect((sheet.setHeaderRow as any).mock.calls[0][0]).toHaveLength(1) |
There was a problem hiding this comment.
Not sure what this was meant to do, as it was already asserted on the previous lines
samwho
approved these changes
May 10, 2024
…adsheet-messes-with-the-data
mike12345567
approved these changes
May 13, 2024
…adsheet-messes-with-the-data
adrinr
deleted the
budi-8222/deleting-a-column-on-google-spreadsheet-messes-with-the-data
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, deleting a column deletes the header cell but not the full column. Because of this, deleting data mixes the order of the columns. We don't want to delete the data as these data might not be created by budibase. Because of this, we will only drop the BB reference but keeping the references in the actual sheet. Adding the deleted column back will backpopulate it in BB.
Also fixing a bug that allowed spamming the
create/edit columnsubmit, causing strange errors.https://github.com/Budibase/budibase/assets/15987277/f6a6f5b5-08ec-4c99-b27e-5dc888fb49db
Addresses
App Export
Launchcontrol
Fixing broken data on google sheet column deletion