Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected row + export data support for grid blocks (new table component) #13426

Merged
merged 19 commits into from May 13, 2024

Conversation

aptkingston
Copy link
Member

@aptkingston aptkingston commented Apr 8, 2024

Description

This PR adds support for hooking into the selected rows of the new table component (grid block).

  • There's a new binding provided by tables for "Selected rows" which are the full selected row objects. This works for any sort of datasource - a big improvement over the old table component. You can then use this as you see fit.
    image

  • Support has been added for the "Export data" button action. No config changes needed - you can just select new table components as well as old ones. Behind the scenes I've moved away from the deprecated "row selection store" but there's no difference to the user. Exporting data still only works for table datasources, as always.
    image

Other stuff

When blurring a grid (clicking outside it) we no longer deselect any selected rows. This applies across the board. Hovered and focused cell will still be unset.

Addresses

Feature branch env

Feature Branch Link

@aptkingston aptkingston added the feature-branch Release this PR code into a feature branch label Apr 9, 2024
@aptkingston aptkingston changed the title New table selected rows Selected row + export data support for grid blocks (new table component) Apr 9, 2024
Copy link
Contributor

@ConorWebb96 ConorWebb96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are a few issues with this feature but they don't seem to be related to this PR. I'll log theses issues separately after we get the export functionality for the grid in.

@aptkingston aptkingston merged commit 5c6d02c into master May 13, 2024
10 checks passed
@aptkingston aptkingston deleted the new-table-selected-rows branch May 13, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-branch Release this PR code into a feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants