New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selected row + export data support for grid blocks (new table component) #13426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aptkingston
changed the title
New table selected rows
Selected row + export data support for grid blocks (new table component)
Apr 9, 2024
ConorWebb96
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are a few issues with this feature but they don't seem to be related to this PR. I'll log theses issues separately after we get the export functionality for the grid in.
1 task
…e into new-table-selected-rows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for hooking into the selected rows of the new table component (grid block).
There's a new binding provided by tables for "Selected rows" which are the full selected row objects. This works for any sort of datasource - a big improvement over the old table component. You can then use this as you see fit.
Support has been added for the "Export data" button action. No config changes needed - you can just select new table components as well as old ones. Behind the scenes I've moved away from the deprecated "row selection store" but there's no difference to the user. Exporting data still only works for table datasources, as always.
Other stuff
When blurring a grid (clicking outside it) we no longer deselect any selected rows. This applies across the board. Hovered and focused cell will still be unset.
Addresses
Feature branch env
Feature Branch Link