Add support for file uploads with custom S3 endpoints #13395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogunpurple
approved these changes
May 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5459 and #5587
Description
Add support for file uploads with custom S3 endpoints. This still may not work with all providers, but most S3 compatible providers do have the same kind of support and similar public URLs (If they are going to be used). I think having a mostly working configuration is much better than the current state of silently not working.
This was tested with google cloud storage and regression tested with S3.
Addresses
Launchcontrol
Add support for file uploads with custom S3 endpoints. (May not work with all providers)