Add migration to support SQS #12676
Closed
Add migration to support SQS #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
added
do not merge
|
Plan Error |
|
This cannot be merged until the migration system is in place |
samwho
reviewed
Jan 2, 2024
| @@ -17,6 +17,7 @@ import { LinkDocument } from "@budibase/types" | |||
| class LinkDocumentImpl implements LinkDocument { | |||
| _id: string | |||
| type: string | |||
| tableId: string | |||
There was a problem hiding this comment.
I'm a little uncertain about this name, because it's not actually a table ID. Could be confusing when reading the code to later find out that it's 2 conjoined table IDs.
Perhaps lookupId?
Comment on lines
+60
to
+62
| _rev?: string | undefined | ||
| createdAt?: string | number | undefined | ||
| updatedAt?: string | undefined |
There was a problem hiding this comment.
Are these necessary? LinkDocument inherits from Document, which defines these already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new app migration to support the future SQS implementation. This will require a deterministic field to support joins, so we are adding a tableId field to internal links in order to achieve this