remove localtunnel #2059
Merged
remove localtunnel #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Dec 27, 2023
|
FYI changes to dependencies and semver is a hotly debated topic but for a security fix like this, imho it would have been nicer to release it within the same major version since now other packages need to be updated to allow the new major version first. |
|
@lsmith77 - thanks. Yeah I did consider that. Honestly I'd be happy to release this same tag into 2.x too (to increase adoption) - it's just hard to judge if it's impacting anyone or not (since Browsersync has both a giant user base + zero telemetry) |
|
angular users would appreciate a release since there is not yet a release of a browsersync 3.0 compatible version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was always an optional code-path, so now anyone wanting to use localtunnel can continue to do so, after installing it themselves.