Merge pull request #1936 from lachieh/socket-io-upgrade

Upgrade to latest version of socket.io due to security vulnerability
BrowserSync · Mar 4, 2022 · 6e8d2b2 · 6e8d2b2
2 parents a7c14c8 + e909447
commit 6e8d2b2
Show file tree

Hide file tree

Showing 9 changed files with 12,835 additions and 7,037 deletions.
diff --git a/packages/browser-sync-client/lib/browser.utils.ts b/packages/browser-sync-client/lib/browser.utils.ts
@@ -132,7 +132,7 @@ export function setScroll(pos) {
  * Hard reload
  */
 export function reloadBrowser() {
-    getWindow().location.reload(true);
+    getWindow().location.reload();
 }
 
 /**
@@ -151,6 +151,8 @@ export function forEach(coll, fn) {
  * @returns {boolean}
  */
 export function isOldIe() {
+  // @ts-ignore - Only IE < 11 has .attachEvent property
+  // https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/platform-apis/aa703974(v=vs.85)
     return typeof getWindow().attachEvent !== "undefined";
 }
 

diff --git a/packages/browser-sync-client/lib/effects/browser-reload.effect.ts b/packages/browser-sync-client/lib/effects/browser-reload.effect.ts
@@ -15,6 +15,6 @@ export function preBrowserReload() {
 export function browserReloadEffect(xs: Observable<any>, inputs: Inputs) {
     return xs.pipe(
         withLatestFrom(inputs.window$),
-        tap(([, window]) => window.location.reload(true))
+        tap(([, window]) => window.location.reload())
     );
 }