Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve template compile performance #538

Merged
merged 28 commits into from
May 8, 2024
Merged

Improve template compile performance #538

merged 28 commits into from
May 8, 2024

Conversation

ghinda
Copy link
Member

@ghinda ghinda commented May 8, 2024

Changes:

  • New content-level store with memoized get functions, to speed up template insert when service worker is inactive.
  • Create a general purpose Messenger class for MessageChannel communication.
  • Use messaging for compiling templates on manifest v2.

ghinda added 28 commits May 4, 2024 11:59
@ghinda
General purpose message-channel messenger class.
a192d2a
@ghinda
Upgrade outdated.
2f08d9e
@ghinda
Use the new messenger class for page.js communication.
520e71e
@ghinda
Downgrade lexical minor version.
1f1cad9 
Latest version throws react import useMemo error.
@ghinda
Improved error handling in the messenger.
a6eba17 
Improved messenger instance refresh in the page-parent script.
Add unit test for ckeditor.
@ghinda
Improve prosemirror unit test clean up.
90d90dc
@ghinda
Improve messenger to not have to specify which is client-server.
c75528d
@ghinda
Initial implementation of the _sender async helper.
a6a6b6b
@ghinda
Implement async helpers.
1a02cb4 
Transform the from and account variables into a private async helper, for faster compiling.
@ghinda
Update unit tests now that compile template is async.
5f65e77
@ghinda
Tweak _sender helper to use messaging to get the account details, ins…
0cd01ad 
…tead of using the store directly.

Use a different method to send the compile message in mv=2, instead of using sandbox compile directly.
@ghinda
Basic unit tests for the messenger class.
2143b69 
Support parallel requests in the messenger.
@ghinda
Separate helpers for each sender prop.
a50def3 
Support context in async helpers.
Compile nested helpers before compiling the main template.
@ghinda
Upgrade outdated.
0b60a06
@ghinda
Upgrade eslint.
02953d2
@ghinda
Fix lint errors with unused errs.
5736e96
@ghinda
Wait for briskine to load before running tests.
63bcb97
@ghinda
Remove code to check for briskine status in playwright tests.
0e9d448
@ghinda
Wrap the client store in a content script store that caches method re…
8bd6d9e 
…sponses.

Speeds up data fetchers since we don't always need to wake up the service worker.
@ghinda
Use store-content instead of store-client in content scripts.
4a75889 
Disable the local keyboard template cache now that we have store-level cache.
@ghinda
Use the content store in the popup, instead of the store client.
25b66b4
@ghinda
Remove the _sender helper and restore previous account-from functiona…
22263ab 
…lity.

Much better performance.
@ghinda
Disable static account cache now that we have the content store.
87a2d8b
@ghinda
Fix issues with event ordering in the new content store.
76f66f5 
Fix issues with logout in the popup.
@ghinda
Bump version.
9db2f9f
@ghinda
Upgrade css-minimizer-webpack-plugin.
46284eb
@ghinda
Catch errors when populating the content store cache.
c5d4b90
@ghinda
Fix issues with not updating dialog template list on login.
adbbac0
@ghinda ghinda self-assigned this May 8, 2024
@ghinda ghinda merged commit c1be809 into master May 8, 2024
1 check passed
@ghinda ghinda deleted the ghinda--compile-perf branch May 8, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghinda ghinda

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ghinda