Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync improvements #529

Merged
merged 17 commits into from
Mar 11, 2024
Merged

Sync improvements #529

merged 17 commits into from
Mar 11, 2024

Conversation

ghinda
Copy link
Member

@ghinda ghinda commented Mar 11, 2024

Changes:

  • Tweak popup sync indicator behavior to show up when autosync is started automatically.
  • Reduce memory usage in the keyboard module, by assigning store events only after first shortcut is used.
  • Reduce number of duplicate store events sent to the content by using a debounced queue.
  • Show the log in form when automatically logged out in the popup.
  • Make sure the bubble is never visible when the dialog is disabled.
  • Fix issues with signing in with a different user while still having cached collections.

ghinda added 17 commits March 7, 2024 16:55
@ghinda
Use a timeout param for the autosync method, instead of a force boolean.
f724e50
@ghinda
Tweak loading indicator behavior:
1d7fc1c 
Show up when refetching was started automatically.
Don't show when opening the popup but refetching was not started.
Articial 1s delay for more predictable behavior.
@ghinda
Tweak refetching collections to reduce requests.
79ce5fa
@ghinda
Formatting on handleErrors.
0c2b005
@ghinda
Remove extra optimization from refetch collections in the store.
43c5ad5
@ghinda
Setup the keyboard store events only after inserting the first template.
d2c4f97 
Refetch collections in parallel in refetch-collections.
@ghinda
Use allSettled in trigger, to make sure we try to send the message ev…
872f0fe 
…erywhere.
@ghinda
Debounce store background triggers, to avoid multiple templates-updat…
1f86cf9 
…ed events.
@ghinda
Add an immediate mode for running the trigger queue.
9923439
@ghinda
Trigger logout when automatically logging out, to show the login dial…
35f2125 
…og again in the popup.
@ghinda
Fix issues with not sending extension data to extension-data-updated …
d7deb5c 
…event.
@ghinda
Fix setting up the events on first keyboard insert.
5a93783
@ghinda
Fix issues with showing the bubble even when the dialog is disabled.
435aa88
@ghinda
Upgrade firebase tools.
950002c
@ghinda
Bump version.
95ca9c6
@ghinda
Remove artificial sync delay.
f00919f
@ghinda
Fix signin issues when logging in with a different user, while still …
5f32011 
…having cached collections.
@ghinda ghinda self-assigned this Mar 11, 2024
@ghinda ghinda merged commit 1a3e846 into master Mar 11, 2024
1 check passed
@ghinda ghinda deleted the ghinda--sync-improvements branch March 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ghinda ghinda

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ghinda