Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a static event name #4677

Merged
merged 1 commit into from
May 14, 2024
Merged

use a static event name #4677

merged 1 commit into from
May 14, 2024

Conversation

dlockhart
Copy link
Member

From the docs I knew these events existed, but they weren't showing up in code search because their names were dynamically built up. Switching to a static definition to help with code searching.

@dlockhart dlockhart requested a review from a team as a code owner May 14, 2024 13:16
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-4677/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@dlockhart dlockhart enabled auto-merge (squash) May 14, 2024 13:23
@dlockhart dlockhart merged commit 0731226 into main May 14, 2024
6 checks passed
@dlockhart dlockhart deleted the dlockhart/static-event-name branch May 14, 2024 13:24
Copy link

🎉 This PR is included in version 2.188.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants