Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the dropdown with accessibility #4626

Draft
wants to merge 63 commits into
base: saif/tableHeaderMain
Choose a base branch
from
Draft

Add the dropdown with accessibility #4626

wants to merge 63 commits into from

Conversation

saifaldin14
Copy link
Contributor

No description provided.

@saifaldin14
GAUD-6124 Add new interim styles for table header
80b9f86
@saifaldin14
fix: Conditionally get the element
56f76ef
@saifaldin14
fix: Add double button
e26d6b5
@saifaldin14
fix: lint errors
4a2a5f4
@saifaldin14
fix: remove useless style
e810cee
@saifaldin14
fix: seperate change to a new PR
c812eef
@saifaldin14
fix: remove padding
61fb495
@saifaldin14
fix: add dropdown
b6793a5
@saifaldin14
fix: Update table cell height to be consistent
86cc902
@saifaldin14
fix: Update table cell height to be consistent
9aaf223
@saifaldin14
fix: Bring back table light border radius
71d4383
@saifaldin14
fix: change line height instead
c844f5e
@saifaldin14
Merge branch 'saif/tableHeaderInterim' into saif/tableHeaderDropdown
30c5519
@saifaldin14
fix: fix focus height
fe5465a
@saifaldin14
fix: update height
1e19d75
@saifaldin14
fix: resolve dropdown
fa0aa18
@saifaldin14
Merge branch 'main' into saif/tableHeaderDropdown
a844c59
@saifaldin14
fix: resolve comments
fba41ca
@saifaldin14
Merge branch 'saif/tableHeaderMain' into saif/tableHeaderDropdown
b3979ce
@saifaldin14
fix: Update button styles
8391528
@saifaldin14
fix: Use slotchange pattern
eca7072
@saifaldin14
fix: resolve css changes
c5d8d74
@saifaldin14
fix: Update styles and test table
576d26f
@saifaldin14
fix: Remove pointer
971e7b7
@saifaldin14
fix: Has sibling
f297140
@saifaldin14
fix: dropdown condition
4b14926
@saifaldin14
fix: Width for focus
762996d
@saifaldin14
fix: Small
4159fc2
@saifaldin14
fix: Resolve condition
969b8ee
@saifaldin14
fix: Start adding accessibility
3d024b5
@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-4626/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Draft
@saifaldin14 saifaldin14 changed the title Add just the dropdown Add the dropdown with accessibility Apr 26, 2024
margaree
margaree reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@margaree margaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in our call feel free to ignore this, but just getting this review in in case you continue working on this today!

components/table/table-col-sort-button.js Outdated Show resolved Hide resolved
components/table/table-col-sort-button.js Outdated Show resolved Hide resolved
components/table/table-col-sort-button.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margaree margaree Awaiting requested review from margaree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saifaldin14 @margaree