POC - Migrate to subscriber controllers #3819
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanherk
commented
Jul 11, 2023
| @@ -196,6 +205,14 @@ export class IdSubscriberController extends BaseSubscriber { | |||
| }); | |||
| } | |||
|
|
|||
| _handlePassthrough(e) { | |||
There was a problem hiding this comment.
Replicating the passthrough functionality added to selection-observer-mixin. Some decisions need to be made here if multiple registries exist.
svanherk
commented
Jul 11, 2023
| if (this._registryObserver) this._registryObserver.disconnect(); | ||
| this._registryControllers.forEach(controller => { | ||
| controller.unsubscribe(this._host); | ||
| }); | ||
| this._idPropertyValue = undefined; |
There was a problem hiding this comment.
I think this is a current bug with disconnected then reconnect IdSubscribers not being able to re-register.
svanherk
commented
Jul 11, 2023
| @@ -153,21 +153,30 @@ export class IdSubscriberController extends BaseSubscriber { | |||
| super(host, name, options); | |||
|
|
|||
| this._idPropertyName = options && options.idPropertyName; | |||
| this._idPropertyValue = this._idPropertyName ? this._host[this._idPropertyName] : undefined; | |||
There was a problem hiding this comment.
I don't think this will ever not be undefined.
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to #1901
POC of how to migrate the form/validation, selection, and labelledby components and mixins to the subscriber controllers.
This is not thoroughly tested and variables are not well-named - this is a starting point.