fix: switch to use dynamic mixin #2086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into the test failures. |
|
Visual diff tests failed - pull request #2087 has been opened with the updated goldens. |
dbatiste
approved these changes
Feb 7, 2022
|
This caused a lot of timing issues in our tests in non-Chrome, so closing this in favour of a BSI solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
for awaithere was causing esbuild to complain (it's used by@web/dev-server) in Firefox.Since the languages passed into this function are a static list, I don't actually think
for awaitwas required. Either way, switching this to use the newerLocalizeDynamicMixinalso resolves this.There are a bunch of places that copied this though, so they may also need to be updated.