the key caching has some race conditions #360
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daryl-mcmillan
commented
Feb 8, 2024
| return null; | ||
| } | ||
|
|
||
| return current.Ref(); |
There was a problem hiding this comment.
this is the main race condition - if the key is replaced between Volatile.Read and this call to .Ref() it will be disposed.
daryl-mcmillan
commented
Feb 8, 2024
| private D2LSecurityToken m_current = null; | ||
|
|
||
| private D2LSecurityToken GetCurrentToken() { | ||
| lock( m_keyRefreshLock ) { | ||
| return m_current?.Ref(); |
There was a problem hiding this comment.
don't let the key be disposed while we're thinking about returning it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is assuming the reference counting via
Dispose()is reasonable - really multiple Dispose calls are supposed to be ok soRef()should probably be returning a wrapper.https://stackoverflow.com/a/5306896/24158