Skip to content

Commit

Permalink
testing(bigquery): correct an integration test expectation (googleapi…
Browse files Browse the repository at this point in the history
…s#9791)

This PR corrects a test expectation around range representation (nil vs a NullTimestamp), and cleans up some spurious logging in a testing cleanup function that it overly noisy.
  • Loading branch information
shollyman committed Apr 17, 2024
1 parent 07f0806 commit 4e43bc2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions bigquery/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2901,11 +2901,10 @@ func TestIntegration_ExportDataStatistics(t *testing.T) {
break
}
if err != nil {
t.Logf("failed to delete bucket: %v", err)
t.Logf("failed to iterate through bucket %q: %v", bucketName, err)
continue
}
err = storageClient.Bucket(bucketName).Object(obj.Name).Delete(ctx)
t.Logf("deleted object %s: %v", obj.Name, err)
}
}()

Expand Down
2 changes: 1 addition & 1 deletion bigquery/params_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ func TestIntegration_OtherParam(t *testing.T) {
},
&RangeValue{
Start: time.Date(2016, 3, 22, 4, 22, 9, 5000, time.FixedZone("neg1-2", -3720)),
End: NullTimestamp{},
End: nil,
},
},
} {
Expand Down

0 comments on commit 4e43bc2

Please sign in to comment.