Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ADTS/AAC #206

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Support ADTS/AAC #206

merged 2 commits into from
Apr 29, 2019

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Apr 29, 2019 •
edited

Relates issues:

  1. FourCC error with aac files #204
  2. Support MPEG-2/AAC #205: Support MPEG-2/AAC

@Borewit Borewit changed the title Support ADTS/AAC7 Support ADTS/AAC Apr 29, 2019
@coveralls
Copy link

coveralls commented Apr 29, 2019 •
edited

Coverage Status

Coverage increased (+0.2%) to 97.298% when pulling 6427018 on support-adts-aac into 9e4ad91 on master.

@Borewit
Copy link
Owner Author

Borewit commented Apr 29, 2019

Slightly changed the way MPEG formats are described:

property old value new value (this PR) considering to update property name to
format.dataformat mp3 MPEG format.container
format.encoder LAME3.99r mp3 format.codec
format.codecProfile V2 V2 format.codecProfile
format.tool LAME3.99r format.tool

@Borewit Borewit merged commit a61d44b into master Apr 29, 2019
@Borewit Borewit deleted the support-adts-aac branch April 29, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Borewit @coveralls