Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Philips DSDIFF (.dff) DSD files #198

Merged
merged 1 commit into from Apr 25, 2019
Merged

Add support for Philips DSDIFF (.dff) DSD files #198

merged 1 commit into from Apr 25, 2019

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Apr 7, 2019 •
edited

Implement #196
Related: Sony .dsf (DSD Stream File) format: #195, PR #197

Sub-tasks:

  • Share IFF (EA-IFF 85) chunk definition between AIFF & DSDIFF
  • Implement DSDIFF parser
  • Unofficial ID3v2 tag in ID3 chunk (as done by SACD foobar2000 plugin)
  • Audio compression types
    • DSD (uncompressed)
      • Bitrate
      • Sample files (small)
      • Unit test(s)
  • Update documentation

Compressed DSD moved to #203

@volumio volumio mentioned this pull request Apr 7, 2019
Closed
@Borewit Borewit changed the title Add support for Philips DSDIF (.dff) SDS files Add support for Philips DSDIFF (.dff) SDS files Apr 7, 2019
@Borewit Borewit changed the title Add support for Philips DSDIFF (.dff) SDS files Add support for Philips DSDIFF (.dff) DSD files Apr 7, 2019
@Borewit Borewit self-assigned this Apr 7, 2019
@coveralls
Copy link

coveralls commented Apr 7, 2019 •
edited

Coverage Status

Coverage increased (+0.03%) to 97.008% when pulling 17c3c6faebf94b3a0f823f1cfd4a98590bb24efa on 196-add-support-for-DSDIFF-format into c27c029 on master.

@Borewit Borewit force-pushed the 196-add-support-for-DSDIFF-format branch from cc6cbb9 to 19284f5 Compare April 7, 2019 08:38
@Borewit
Copy link
Owner Author

Borewit commented Apr 7, 2019

DSDIFF is more painful than implementing DSF:

  1. I don't have sample DSDIFF file with metadata (maybe it is not possible to embed metadata?)
  2. Not supported by MP3tag
  3. Not sure yet how to calculate the duration

@Borewit Borewit mentioned this pull request Apr 9, 2019
Merged
6 tasks
@Borewit Borewit force-pushed the 196-add-support-for-DSDIFF-format branch 3 times, most recently from b741d16 to 039d025 Compare April 12, 2019 06:51
@Borewit Borewit mentioned this pull request Apr 13, 2019
Closed
2 tasks
@Borewit Borewit mentioned this pull request Apr 22, 2019
Merged
3 tasks
@Borewit Borewit force-pushed the 196-add-support-for-DSDIFF-format branch from 17c3c6f to 3dcbe4c Compare April 25, 2019 06:30
@Borewit Borewit mentioned this pull request Apr 25, 2019
Closed
3 tasks
@Borewit Borewit merged commit 4f7a285 into master Apr 25, 2019
@Borewit Borewit deleted the 196-add-support-for-DSDIFF-format branch May 19, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Borewit @coveralls