Security fix. Upgrade to gulp 4.0.0

[isholgueras]

The security issue is with gulp 3.9.1 and the fix is to upgrade to gulp 4.0.0
Following the official documentation and this post, I've upgraded this to gulp 4.0.0.

It's important to point out that things like:
gulp.task('default', ['a', 'b'], function() { /*code*/ });
become
gulp.task('default', gulp.series('a', 'b', function() { /*code*/ }));

and also, tasks must be defined before being called. You must define tasks like sass, sass:lint,... before calling it. Otherwise you will get this error:
AssertionError [ERR_ASSERTION]: Task never defined: sass:lint

I didn't see anything in the README.md to indicate how to upgrade, from 3.9.1 to 4.0.0 so I didn't added anything there.

[jameswilson]

@isholgueras does this also resolve the upstream security issue identified a few months ago on #3 ?

[jameswilson]

I'm fine with updating gulp here, but wonder what kind of effects this is going to have on all projects that use this. Will they also need to update gulp? or just update gulp-frontend-tasks? I'm not sure what the upgrade process is for projects that use this framework. I think you could look at the obermeyer theme to figure out.

[isholgueras]

The process is to upgrade gulp for this project. If this project is part of the client project, we should update the client project as well, but imo, if we use this just for compile sass to scss files, uglify js and so forth, we're fine.

The security issue comes if you're using this library to get requests from internet as a application server

[isholgueras]

And yes @jameswilson , this PR fixes all the security issues (high, mid, low) this project have.
Basically, I've executed npm audit to verify what is happening, then a npm audit fix to update just those packages with security issue in their minor and patch updates. minimatch@2.0.10 doesn't upgrade because of its depencencies comes from gulp@3.9.1, so to upgrade to minimatch@3.0.2 I was forced to upgrade to gulp@4.0.0

I followed the official documentation and this post:
https://www.liquidlight.co.uk/blog/article/how-do-i-update-to-gulp-4/

[jameswilson]

Thanks! Merged.