Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: useStorage useCallback and useMemo #6549

Merged
merged 4 commits into from
May 20, 2024
Merged

REF: useStorage useCallback and useMemo #6549

merged 4 commits into from
May 20, 2024

Conversation

marcosrdz
Copy link
Member

No description provided.

@marcosrdz marcosrdz self-assigned this May 12, 2024
@marcosrdz marcosrdz requested a review from limpbrains May 12, 2024 21:15
Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not it feels a bit too much.

whats the point of those useCallbacks?

i dont want to remember to type .current for all the properties like txMetadata.current

@marcosrdz
Copy link
Member Author

not it feels a bit too much.

whats the point of those useCallbacks?

i dont want to remember to type .current for all the properties like txMetadata.current
So if it called again and the items in the depends array havent changed it'll return the last obtained value instead of refetching

@marcosrdz
Copy link
Member Author

not it feels a bit too much.

whats the point of those useCallbacks?

i dont want to remember to type .current for all the properties like txMetadata.current

Addressed the .current issue

@GladosBlueWallet
Copy link
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment

Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. conflicts tho

@GladosBlueWallet
Copy link
Collaborator

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/5hfa4tpxawczrgppr3vjrbukxe?device=pixel4

download apk

@GladosBlueWallet GladosBlueWallet merged commit 1a6c777 into master May 20, 2024
13 checks passed
@GladosBlueWallet
Copy link
Collaborator

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

@GladosBlueWallet GladosBlueWallet deleted the storageuse branch May 20, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants