-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: Place network calls in InteractionManager #6548
Conversation
♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫ [android in browser] https://appetize.io/app/ghqlufoxw5ob374xapr4ytkbxy?device=pixel4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit doubtful about this one. do we really want to delay network fetch in favor of more smooth animations..?
@limpbrains wdyt?
Its more of a debounce behavior |
Wake the fuck up samurai, we have PRs to merge [all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is usefull.
Would prefer Promise syntax thought
await new Promise((resolve) => {
InteractionManager.runAfterInteractions(() => resolve(null));
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if @limpbrains blessed it then its fine with me too
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
No description provided.