Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Place network calls in InteractionManager #6548

Merged
merged 1 commit into from
May 14, 2024
Merged

REF: Place network calls in InteractionManager #6548

merged 1 commit into from
May 14, 2024

Conversation

marcosrdz
Copy link
Member

No description provided.

@marcosrdz marcosrdz self-assigned this May 12, 2024
@GladosBlueWallet
Copy link
Collaborator

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/ghqlufoxw5ob374xapr4ytkbxy?device=pixel4

download apk

Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit doubtful about this one. do we really want to delay network fetch in favor of more smooth animations..?

@limpbrains wdyt?

@marcosrdz
Copy link
Member Author

a bit doubtful about this one. do we really want to delay network fetch in favor of more smooth animations..?

@limpbrains wdyt?

Its more of a debounce behavior

@GladosBlueWallet
Copy link
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains

Copy link
Collaborator

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is usefull.
Would prefer Promise syntax thought

await new Promise((resolve) => {
  InteractionManager.runAfterInteractions(() => resolve(null));
});

Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if @limpbrains blessed it then its fine with me too

@GladosBlueWallet GladosBlueWallet merged commit 552fb95 into master May 14, 2024
13 checks passed
@GladosBlueWallet
Copy link
Collaborator

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants