ADD: P2P Feature for a more user friendly multisig creation experience #6512
Conversation
| "ms_help_title5": "अग्रिम मोड", | ||
| "p2p_title": "P2P", | ||
| "creating_p2p": "सत्र बनाउँदै...", | ||
| "joining_p2p": "सत्रमा सामेल हुनुहोस्...", |
There was a problem hiding this comment.
Sorry for not understanding. What does Aseel mean in this context?
|
Hello @limpbrains @ncoelho @Overtorment! Wanted to ask if there is any chance of passing this PR and if there are any requirements? |
|
I really like this idea but saw this works only in the local network via Bonjour (zeroconf?) |
Yes, this was designed to work only on local network because it fits all common use cases for multisig. Thought about developing it with Nostr as a foundation but the idea of sifting through 25 other open sessions to find the session you’re looking for felt unpleasant. Also was thinking it would be more secure to have it use local networks instead of opening things up to the non-local. What use cases do you think would benefit from having it use a non-local network, I’m curious? |
|
I think, most of the time I was using multisig, the participants haven't been in the same place as me. So I thought:
|
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @ncoelho] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/ncoelho |
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment |
Short Description
This feature allows
nusers to create a Multisig wallet collaboratively each with their own BlueWallet app. There are two modes for P2P, hosting a session and joining a session. Session hosts advertise their presence and in parallel the rest of the peers search for a session to join. All peers join the host session and the host coordinates the process until peers share their key with all other nodes in the network. All communications are performed using encrypted TLS sockets on the local network (Wi-Fi and Hotspot are supported). react-native-p2p-secure, a new library was created to enable multi-platform P2P communication for this purpose.Through this sharing process, only the XPUBs are shared. The
onBarScannedmethod is reused when an XPUB is received from a peer to increase logic sharing and minimize logic error risks.Below is a screen recording of a 2-of-3 multisig wallet creation using the P2P feature:
Screen.Recording.2024-05-05.at.12.45.48.AM.mp4
Motivation
This feature allows for a more intuitive approach for multisig wallet adoption. This approach might be a step towards simplifying multisig for the masses and increasing adoption by adopting a more familiar sharing mechanism to the average user while the rest of the sharing process is black-boxed. This work (as well as the react-native-p2p-secure library) was in an effort to complete the HRF bounty
#8 Easy Mobile Multisig. The current bounty is for 1 BTC (before taxes), given that this is a relatively big PR, some effort from people other than myself will most probably be required to bake this into the app. Given this fact, I am willing to commit a 7.5% bounty share (of the net amount) to additional contributors and BlueWallet maintainers wishing to add some effort to the passing of this PR.I have spent quite a while working on this, feedback is appreciated, however, I will be working minimally on this moving forward, I have other things to prioritize, so I hope the bounty share is enough to encourage contributors to join in on this and get this going before the end of year deadline.
Note: Translations have been performed using GPT-4. It has been proven to perform quite well for translation tasks. Hope this is ok. Tried to make this PR as complete as possible.