REF: Use interaction manager for tx refresh #6463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫ [android in browser] https://appetize.io/app/iu2zgnuq7mtmw2xn7s5b6i445y?device=pixel4 |
Overtorment
requested changes
Apr 28, 2024
Comment on lines
+114
to
+116
| BlueApp.fetchSenderPaymentCodes(lastSnappedTo), | ||
| fetchWalletBalances(lastSnappedTo), | ||
| fetchWalletTransactions(lastSnappedTo), |
There was a problem hiding this comment.
unfortunately, cant parallelize those 3, they have to be sequential.
- fetch payment codes finds addresses from our payers
- fetch balance finds all the used addresses AND fetches all balances for all addresses
- finally, fetch txs gets all those addressesand fetches all their txs
limpbrains
requested changes
Apr 28, 2024
| if (showUpdateStatusIndicator) { | ||
| setWalletTransactionUpdateStatus(WalletTransactionsStatus.ALL); | ||
| const refreshAllWalletTransactions = async (lastSnappedTo?: number, showUpdateStatusIndicator: boolean = true): Promise<void> => { | ||
| await InteractionManager.runAfterInteractions(async () => { |
There was a problem hiding this comment.
await is not needed, runAfterInteractions
Instead of using callback, I prefer Promise:
await new Promise((resolve) => {
InteractionManager.runAfterInteractions(() => resolve(null));
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InteractionManager helps minimizing UI hangs