ADD: Border Wallets

[3bitcoins]

Replaces #5669

This is an independently developed implementation of Border Wallets which brings similar features, but solves numerous key issues with the initial PR:

• No codebase overhaul (This implementation does not change any existing features, compared to 5,521 LOC changed in the other implementation. Additionally, it does not implement any new wallet types, as all features can be done without doing so.)
• Decreased LOC in general: 11,070 additions -> 1,362 additions
• Improved UX (More straightforward, and explains to the user the process of creating a border wallet. There are no screens with multiple ambiguous buttons, and you are not expected to know how to use a border wallet beforehand.)
• Less dependencies (Only 1 new dependency, for pdfs, compared to 10?? in the other implementation)
• No unnecessary files or changes

[marcosrdz]

Conflicts

[3bitcoins]

I'll fix this when #5722 is merged, because it reuses that logic

[3bitcoins]

@limpbrains @Overtorment This is now ready for review

[3bitcoins]

@Overtorment is there any chance you could review this?

[Overtorment]

i reviewed it a bit, not deeply.
first, of all, i dont really like the feature, and i dont think it will do any good to anyone, ever.
but, we can consider adding it to "tools" section, so it wont occupy precious real-estate on already UI-heavy add/import screens.

also, some issues:

• extra dep. i think allowing backups in pure html is good enough, no need for a pdf conversion. luckily we already have everyting to create html, save it fo file (via fs) and export for user
• zero tests in this pr. at the very least id like to know that our implementation is compatible with the reference one via shared test vectors
• new components should be in components/

[3bitcoins]

@Overtorment Hey, thanks for your review

i reviewed it a bit, not deeply. first, of all, i dont really like the feature, and i dont think it will do any good to anyone, ever. but, we can consider adding it to "tools" section, so it wont occupy precious real-estate on already UI-heavy add/import screens.

Ever since I discovered it i've been using it to backup my seeds, and it's been extremely useful at least to me, anecdotally

• extra dep. i think allowing backups in pure html is good enough, no need for a pdf conversion. luckily we already have everyting to create html, save it fo file (via fs) and export for user

the PDF feature is in consistent in the reference implementation as well as Sparrow Wallet's implementation; it's for compatibility

• zero tests in this pr. at the very least id like to know that our implementation is compatible with the reference one via shared test vectors
• new components should be in components/

I will resolve these issues if you get back to me on whether or not the PDF export is a hard no or not

[Overtorment]

if we can get rid of pdf dependency we can add it to tools section, but this thing wont help people cross real dangerous borders (you know, the ones where guards beat the shit out of you if they find anything resembling crypto backups on you)