Merge feature to development #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatymahmed
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Hi @Blasco9,
You have done a great job in this project, everything looks good 🎉🎉
It's a 👍🏾 from me!
✔️ Approved!
[OPTIONAL]
- Even though the main aim of this project is to test your knowledge of active records, models, and associations, I highly encourage you to add views to your app so that users can create posts using forms rather than using the console, that way it will look more like Reddit and it will be easier to use for users who do not know how to use the console 😀.
Good luck with your next projects.
|
Thanks for your review, I will try to implement the front end part when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I created the new rails app, created the models, added validations and relationships to such models and fixed all linter errors.
EDIT: I added the following cops
Lint/RaiseException:
Enabled: false
Lint/StructNewOverride:
Enabled: false
Style/HashEachMethods:
Enabled: false
Style/HashTransformKeys:
Enabled: false
Style/HashTransformValues:
Enabled: false
As suggested in this PR microverseinc/linters-config#63