Skip to content

enhancement(example): rp2040 + lara-r6 example #130

enhancement(example): rp2040 + lara-r6 example

enhancement(example): rp2040 + lara-r6 example #130

Triggered via pull request February 15, 2024 10:11
Status Failure
Total duration 54s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 46 warnings
Build & Test
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused `core::result::Result` that must be used: src/asynch/runner.rs#L511
warning: unused `core::result::Result` that must be used --> src/asynch/runner.rs:511:21 | 511 | self.handle_urc(event).await; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 511 | let _ = self.handle_urc(event).await; | +++++++
redundant closure: src/asynch/state.rs#L335
warning: redundant closure --> src/asynch/state.rs:335:22 | 335 | .map_err(|x| Error::SubscriberOverflow(x))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::SubscriberOverflow` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
redundant closure: src/asynch/state.rs#L222
warning: redundant closure --> src/asynch/state.rs:222:22 | 222 | .map_err(|x| Error::SubscriberOverflow(x))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::SubscriberOverflow` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
redundant closure: src/asynch/state.rs#L209
warning: redundant closure --> src/asynch/state.rs:209:22 | 209 | .map_err(|x| Error::SubscriberOverflow(x))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::SubscriberOverflow` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
unneeded `return` statement: src/asynch/runner.rs#L910
warning: unneeded `return` statement --> src/asynch/runner.rs:910:9 | 910 | return Err(Error::ContextActivationTimeout); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 910 - return Err(Error::ContextActivationTimeout); 910 + Err(Error::ContextActivationTimeout) |
unneeded `return` statement: src/asynch/runner.rs#L689
warning: unneeded `return` statement --> src/asynch/runner.rs:689:9 | 689 | return Ok(false); | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 689 - return Ok(false); 689 + Ok(false) |
redundant guard: src/asynch/runner.rs#L358
warning: redundant guard --> src/asynch/runner.rs:358:43 | 358 | Ok(PinStatus { code }) if code == PinStatusCode::Ready => { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `#[warn(clippy::redundant_guards)]` on by default help: try | 358 - Ok(PinStatus { code }) if code == PinStatusCode::Ready => { 358 + Ok(PinStatus { code: PinStatusCode::Ready }) => { |
this let-binding has unit value: src/asynch/runner.rs#L102
warning: this let-binding has unit value --> src/asynch/runner.rs:102:9 | 102 | / let alive = match self.at.send(&AT).await { 103 | | Ok(_) => { 104 | | return Ok(true); 105 | | } ... | 108 | | } 109 | | }; | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[warn(clippy::let_unit_value)]` on by default help: omit the `let` binding | 102 ~ match self.at.send(&AT).await { 103 + Ok(_) => { 104 + return Ok(true); 105 + } 106 + Err(err) => { 107 + return Err(Error::Atat(err)); 108 + } 109 + }; |
redundant closure: src/asynch/control.rs#L59
warning: redundant closure --> src/asynch/control.rs:59:22 | 59 | .map_err(|e| Error::Atat(e)) | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::Atat` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
redundant closure: src/asynch/control.rs#L50
warning: redundant closure --> src/asynch/control.rs:50:22 | 50 | .map_err(|e| Error::Atat(e)) | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Error::Atat` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
method `init` is never used: src/asynch/control.rs#L22
warning: method `init` is never used --> src/asynch/control.rs:22:25 | 17 | impl<'a, AT: AtatClient> Control<'a, AT> { | ---------------------------------------- method in this implementation ... 22 | pub(crate) async fn init(&mut self) -> Result<(), Error> { | ^^^^
function `kill_time` is never used: src/module_timing.rs#L56
warning: function `kill_time` is never used --> src/module_timing.rs:56:8 | 56 | pub fn kill_time() -> Option<Duration> { | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
unused variable: `profile_id`: src/asynch/runner.rs#L821
warning: unused variable: `profile_id` --> src/asynch/runner.rs:821:9 | 821 | profile_id: ProfileId, | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_profile_id`
unused variable: `model_id`: src/asynch/runner.rs#L190
warning: unused variable: `model_id` --> src/asynch/runner.rs:190:13 | 190 | let model_id = self.at.send(&GetModelId).await?; | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_model_id`
unused variable: `alive`: src/asynch/runner.rs#L102
warning: unused variable: `alive` --> src/asynch/runner.rs:102:13 | 102 | let alive = match self.at.send(&AT).await { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_alive` | = note: `#[warn(unused_variables)]` on by default
variable does not need to be mutable: src/asynch/mod.rs#L64
warning: variable does not need to be mutable --> src/asynch/mod.rs:64:9 | 64 | let mut control = Control::new(state_ch, AtHandle(&state.at_handle)); | ----^^^^^^^ | | | help: remove this `mut`
variable does not need to be mutable: src/asynch/mod.rs#L54
warning: variable does not need to be mutable --> src/asynch/mod.rs:54:9 | 54 | let mut runner = Runner::new( | ----^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default
unused import: `crate::asynch::state::OperationState::DataEstablished`: src/asynch/state.rs#L7
warning: unused import: `crate::asynch::state::OperationState::DataEstablished` --> src/asynch/state.rs:7:5 | 7 | use crate::asynch::state::OperationState::DataEstablished; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::error::Error::Network`: src/asynch/runner.rs#L49
warning: unused import: `crate::error::Error::Network` --> src/asynch/runner.rs:49:5 | 49 | use crate::error::Error::Network; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `Ipv4Addr`, `Ipv6Addr`: src/asynch/runner.rs#L45
warning: unused imports: `Ipv4Addr`, `Ipv6Addr` --> src/asynch/runner.rs:45:18 | 45 | use no_std_net::{Ipv4Addr, Ipv6Addr}; | ^^^^^^^^ ^^^^^^^^
unused import: `heapless::String`: src/asynch/runner.rs#L44
warning: unused import: `heapless::String` --> src/asynch/runner.rs:44:5 | 44 | use heapless::String; | ^^^^^^^^^^^^^^^^
unused import: `crate::error::GenericError::Timeout`: src/asynch/runner.rs#L38
warning: unused import: `crate::error::GenericError::Timeout` --> src/asynch/runner.rs:38:5 | 38 | use crate::error::GenericError::Timeout; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::SetPacketSwitchedAction`: src/asynch/runner.rs#L33
warning: unused import: `crate::command::psn::SetPacketSwitchedAction` --> src/asynch/runner.rs:33:5 | 33 | use crate::command::psn::SetPacketSwitchedAction; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::types::PacketSwitchedNetworkDataParam`: src/asynch/runner.rs#L32
warning: unused import: `crate::command::psn::types::PacketSwitchedNetworkDataParam` --> src/asynch/runner.rs:32:5 | 32 | use crate::command::psn::types::PacketSwitchedNetworkDataParam; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::types::PacketSwitchedAction`: src/asynch/runner.rs#L31
warning: unused import: `crate::command::psn::types::PacketSwitchedAction` --> src/asynch/runner.rs:31:5 | 31 | use crate::command::psn::types::PacketSwitchedAction; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::responses::PacketSwitchedNetworkData`: src/asynch/runner.rs#L28
warning: unused import: `crate::command::psn::responses::PacketSwitchedNetworkData` --> src/asynch/runner.rs:28:5 | 28 | use crate::command::psn::responses::PacketSwitchedNetworkData; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `IdentificationInformation`: src/asynch/runner.rs#L20
warning: unused import: `IdentificationInformation` --> src/asynch/runner.rs:20:72 | 20 | use crate::command::general::{GetCCID, GetFirmwareVersion, GetModelId, IdentificationInformation}; | ^^^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `PowerDown`, `PowerUp`: src/asynch/runner.rs#L14
warning: unused imports: `PowerDown`, `PowerUp` --> src/asynch/runner.rs:14:44 | 14 | use crate::asynch::state::OperationState::{PowerDown, PowerUp}; | ^^^^^^^^^ ^^^^^^^
unused import: `LinkState`: src/asynch/runner.rs#L12
warning: unused import: `LinkState` --> src/asynch/runner.rs:12:26 | 12 | use super::state::{self, LinkState}; | ^^^^^^^^^
unused import: `core::str::FromStr`: src/asynch/runner.rs#L8
warning: unused import: `core::str::FromStr` --> src/asynch/runner.rs:8:5 | 8 | use core::str::FromStr; | ^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::SetPacketSwitchedConfig`: src/asynch/runner.rs#L7
warning: unused import: `crate::command::psn::SetPacketSwitchedConfig` --> src/asynch/runner.rs:7:5 | 7 | use crate::command::psn::SetPacketSwitchedConfig; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::GetPacketSwitchedNetworkData`: src/asynch/runner.rs#L5
warning: unused import: `crate::command::psn::GetPacketSwitchedNetworkData` --> src/asynch/runner.rs:5:5 | 5 | use crate::command::psn::GetPacketSwitchedNetworkData; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::types::ProtocolType`: src/asynch/runner.rs#L2
warning: unused import: `crate::command::psn::types::ProtocolType` --> src/asynch/runner.rs:2:5 | 2 | use crate::command::psn::types::ProtocolType; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::command::psn::types::PacketSwitchedParam`: src/asynch/runner.rs#L1
warning: unused import: `crate::command::psn::types::PacketSwitchedParam` --> src/asynch/runner.rs:1:5 | 1 | use crate::command::psn::types::PacketSwitchedParam; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused imports: `Duration`, `with_timeout`: src/asynch/control.rs#L5
warning: unused imports: `Duration`, `with_timeout` --> src/asynch/control.rs:5:20 | 5 | use embassy_time::{with_timeout, Duration}; | ^^^^^^^^^^^^ ^^^^^^^^
unused import: `core::task::Poll`: src/asynch/control.rs#L2
warning: unused import: `core::task::Poll` --> src/asynch/control.rs:2:5 | 2 | use core::task::Poll; | ^^^^^^^^^^^^^^^^
unused import: `core::future::poll_fn`: src/asynch/control.rs#L1
warning: unused import: `core::future::poll_fn` --> src/asynch/control.rs:1:5 | 1 | use core::future::poll_fn; | ^^^^^^^^^^^^^^^^^^^^^
unused import: `heapless::String`: src/config.rs#L3
warning: unused import: `heapless::String` --> src/config.rs:3:5 | 3 | use heapless::String; | ^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unneeded sub `cfg` when there is only one condition: src/asynch/runner.rs#L266
warning: unneeded sub `cfg` when there is only one condition --> src/asynch/runner.rs:266:15 | 266 | #[cfg(any(feature = "toby-r2"))] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "toby-r2"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
unneeded sub `cfg` when there is only one condition: src/asynch/runner.rs#L182
warning: unneeded sub `cfg` when there is only one condition --> src/asynch/runner.rs:182:15 | 182 | #[cfg(any(feature = "lara-r6"))] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "lara-r6"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
unneeded sub `cfg` when there is only one condition: src/config.rs#L105
warning: unneeded sub `cfg` when there is only one condition --> src/config.rs:105:11 | 105 | #[cfg(any(feature = "automatic-apn"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "automatic-apn"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg = note: `#[warn(clippy::non_minimal_cfg)]` on by default
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/