feat: encrypt and return backup key by default #4551
Draft
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericli-bitgo
force-pushed
the
backups-by-default
branch
from
a1a7a66
to
f1a1e80
Compare
There was a problem hiding this comment.
@davidkaplanbitgo has identified that these actions will be breaking changes per the ticket information. Commit needs to reflect that if it is the case.
TICKET: BTC-1174 BREAKING CHANGE: changes the default behavior of generateWallet
ericli-bitgo
force-pushed
the
backups-by-default
branch
from
f67a2c2
to
2d9be25
Compare
alebusse
reviewed
May 22, 2024
| @@ -264,6 +264,9 @@ export class Keychains implements IKeychains { | |||
| // if the provider is undefined, we generate a local key and add the source details | |||
| const key = this.create(); | |||
| _.extend(params, key); | |||
| if (params.passphrase !== undefined) { | |||
| _.extend(params, { encryptedPrv: this.bitgo.encrypt({ input: key.prv, password: params.passphrase }) }); | |||
| } | |||
There was a problem hiding this comment.
checking line 273, do we want to return the prv and the encryptedPrv ?
There was a problem hiding this comment.
No, the params defined here and above get sent to WP via line 272.
line 273 annotates the response from WP with the prv, so the PRV doesn't actually get sent to WP.
| @@ -435,7 +436,7 @@ export class Wallets implements IWallets { | |||
| throw new Error('cannot generate backup keypair without passphrase'); | |||
| } | |||
| // No provided backup xpub or address, so default to creating one here | |||
| return this.baseCoin.keychains().createBackup({ reqId }); | |||
| return this.baseCoin.keychains().createBackup({ reqId, passphrase: params.passphrase }); | |||
There was a problem hiding this comment.
Is this the only call-site we need to update?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: BTC-1174