Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-625: Upgrade lodash packages for CVE-2019-10744 fix #425

Merged
merged 1 commit into from Jul 10, 2019

Conversation

tylerlevine
Copy link
Contributor

No description provided.

@tylerlevine
Copy link
Contributor Author

See lodash/lodash#4336 for more info

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #425 into master will increase coverage by 22.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #425       +/-   ##
===========================================
+ Coverage    38.7%   60.93%   +22.23%     
===========================================
  Files          74       75        +1     
  Lines        9921     9928        +7     
  Branches     2157     2158        +1     
===========================================
+ Hits         3840     6050     +2210     
+ Misses       5424     2933     -2491     
- Partials      657      945      +288
Flag Coverage Δ
#integration 38.71% <ø> (+0.01%) ⬆️
#unit 54.86% <ø> (?)
Impacted Files Coverage Δ
src/v2/trading/trade.ts 100% <0%> (ø)
src/v2/coins/bsv.ts 35.06% <0%> (+1.29%) ⬆️
src/keychains.ts 34% <0%> (+1.33%) ⬆️
src/v2/coinFactory.ts 94.84% <0%> (+2.06%) ⬆️
src/v2/coins/token.ts 71.52% <0%> (+2.64%) ⬆️
src/util.ts 64.78% <0%> (+2.81%) ⬆️
src/v2/coins/tbch.ts 78.57% <0%> (+3.57%) ⬆️
src/v2/coins/txlm.ts 78.57% <0%> (+3.57%) ⬆️
src/index.ts 96% <0%> (+4%) ⬆️
src/v2/coins/txrp.ts 76% <0%> (+4%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdaa15...50148c6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #425 into master will increase coverage by 22.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #425       +/-   ##
===========================================
+ Coverage    38.7%   60.93%   +22.23%     
===========================================
  Files          74       75        +1     
  Lines        9921     9928        +7     
  Branches     2157     2158        +1     
===========================================
+ Hits         3840     6050     +2210     
+ Misses       5424     2933     -2491     
- Partials      657      945      +288
Flag Coverage Δ
#integration 38.71% <ø> (+0.01%) ⬆️
#unit 54.86% <ø> (?)
Impacted Files Coverage Δ
src/v2/trading/trade.ts 100% <0%> (ø)
src/v2/coins/bsv.ts 35.06% <0%> (+1.29%) ⬆️
src/keychains.ts 34% <0%> (+1.33%) ⬆️
src/v2/coinFactory.ts 94.84% <0%> (+2.06%) ⬆️
src/v2/coins/token.ts 71.52% <0%> (+2.64%) ⬆️
src/util.ts 64.78% <0%> (+2.81%) ⬆️
src/v2/coins/tbch.ts 78.57% <0%> (+3.57%) ⬆️
src/v2/coins/txlm.ts 78.57% <0%> (+3.57%) ⬆️
src/index.ts 96% <0%> (+4%) ⬆️
src/v2/coins/txrp.ts 76% <0%> (+4%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdaa15...50148c6. Read the comment docs.

@tylerlevine tylerlevine merged commit 47f1e23 into master Jul 10, 2019
@0xabrarhussain 0xabrarhussain deleted the CT-625-fix-cve-2019-10744 branch October 14, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants