-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tests with TaxoNet as default classifier #7
Conversation
which is version-dependent
tests are passing locally. this is ready for CR it might be worth bumping the version number immediately after merging this |
tests are passing on py36 but failing on py35
@jtcramer can you help? |
Sorry, finally getting a look at this. It looks like the issue is caused by the PyPI package llvmlite for Python 3.5 no longer being supported, due to Python 3.5 no longer receiving active support from the Python team: numba/llvmlite#471 So perhaps it is wise to just drop support for Python 3.5, since Python 3.5 has already reached EOL. |
Regarding the code fixes, it looks fine to me. |
In response to this it might be a good idea to start supporting Python 3.7 and Python 3.8 (we can probably hold off on 3.9 since it was just released last month) |
This comes from librosa and resampy's dependency on numba, which requires llvmlite: librosa/librosa#1104 (comment) |
Noted. Will update the PR to remove py35 and enable py37 and py38 |
sounds like you're on it :) |
…id TF 2.x from being installed, which we have not yet handled
d9ee8f5
to
c34ce06
Compare
@jtcramer merge? |
fixes #5