Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.9.4 #57

Merged
merged 6 commits into from
May 2, 2023
Merged

Version 0.9.4 #57

merged 6 commits into from
May 2, 2023

Conversation

ehudkr
Copy link
Collaborator

@ehudkr ehudkr commented May 2, 2023

Some small fixes and additions clumped together:

  1. Fix: Loading survival data with load_nhefs_survival now respects the augment and onehot arguments
  2. Enh: Better tests to NHEFS data loading
  3. Enh: Allow different covariate specification to weight and outcome models in WeightedStandardizedSurvival
  4. Fix: Allow specifying no covariates (e.g., intercept-only models) in doubly robust (and WeightedStandardizedSurvival) models
  5. Drop the numpy restriction that was introduced due to a mismatch between matplotlib and numpy
    Fix support for scikit-learn>=1.2.0 and Numpy=1.24.0 #52 (comment)

ehudkr added 6 commits May 2, 2023 15:19
@ehudkr
Add tests for onehot, augment, and mutual index
3cae7fa 
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr
Fix onehot and augment in NHEFS survival data
d284bca 
Were ignored so far.

Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr
Allow no covariates (intercept-only model) in doubly robust models
15b63f3 
Current implementation confused an empty list (`[]`) with `None`
(meaning all covariates)

Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr
Add covariate specification to models in WeightedStandardizedSurvival
14741f4 
Allow specifying different covariate sets to the outcome model and
weight model in `WeightedStandardizedSurvival`.

Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr
Bump version: 0.9.4
263cf9a 
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr
Revert numpy restriction due to mismatch with matplotlib
02a3cdb 
Signed-off-by: Ehud-Karavani <ehud.karavani@ibm.com>
@ehudkr ehudkr merged commit 942fce7 into master May 2, 2023
9 checks passed
@ehudkr ehudkr deleted the survival-data-load branch May 2, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ehudkr