Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to suds-community #192

Closed
wants to merge 2 commits into from
Closed

switch to suds-community #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c900111
switch to suds-community
graingert Sep 8, 2021
3dc3b6a
Update setup.py
graingert Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
history = f.read().replace('.. :changelog:', '')

requirements = [
'suds-jurko==0.6.0',
'suds-community>=1.0.0b1',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this version instead of 0.8.5

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suds-community/suds#58 (comment)

Copy link
Collaborator

@qitia qitia Sep 22, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

While test locally, I found there is some difference between jurko version and the community version when build an object. in jurko version, a complex attribute is created regardless its occurrence count and optional or not.

Jurko version
setattr(data, type.name, value)

Community version
setattr(data, type.name, value if not type.optional() or type.multi_occurrence() else None)

I am not sure if there is customer already depends on this jurko feature, if we upgrade to community, this will break those customers. any idea?

Copy link

@bmoe872 bmoe872 Sep 23, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue with this as a customer of Bing. I think this will be fine. Also could really use this fix, as it's blocking fresh installs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also break our bulk mapping. Sample code and here: the entity is null with this sudo-community implementation and will bring trouble.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a runnable example or a test case?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try this exmple.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see this issue for more background on why this was changed: suds-community/suds#14, however, that should have reverted the behavior to the 0.6.0 behavior.

'future',
'six',
'requests',
Expand Down