New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed material-ui from project #236
Conversation
Here are my opinions on the matter.
|
Should we provide any structure to what that theme should look like? And should it be a separate file, or just a variable or something on |
IMO it doesn't need any structure, but it should be in a separate file. What do you think? |
src/theme.js
Outdated
const { default: CreateMuiTheme } = require('@material-ui/core/styles/createMuiTheme'); | ||
const theme = { | ||
colors: { | ||
duckBill: '#DB2F2A' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may swap this for a more generic name like "primary" or "secondary," similar to how we did this with the material-ui theme in the material branch
Closing since the purpose of this draft PR wasn't to merge into a branch, but to be reviewed as a standalone branch. |
Creating a draft PR for code review and comments on this recipe.
This removes material-ui and several styles from the project to get closer to an unstyled version.
There are a few open questions I want to answer before I consider this good to go:Should we include a default or commented-outWe added a theme with an example color objecttheme
?Should we re-introduce the GlobalStyles component?Re-introduced normalize styles and an example of abody
styleShould we remove all css from this branch, or keep some in as a means of example usage?Kept a few examplesShould I remove thePoof馃挩, gonepackage-lock
from this branch?