Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login middlend #10

Merged
merged 6 commits into from Nov 23, 2022
Merged

Login middlend #10

merged 6 commits into from Nov 23, 2022

Conversation

marlonbrs
Copy link
Contributor

Most of the changes here are meant to setup the client needed to make requests. I used another project as reference for most of the code here. For the most part, it was pretty straightforward but the difference in axios version caused some unexpected behavior.

Using axios latest version with our current implementation of creating an axios client caused AxiosError: options must be an object. To fix this, I just followed something I saw here.

Testing:

To test this out, I had a pallies server running locally. I did create a temporary register action in the middle end to add some users and then logged in using the credentials.

Copy link
Contributor

@bmleight bmleight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 💯

const { data: results } = await client.get('/validate');


return results.pallie;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tylerconstance tylerconstance merged commit e9c3c54 into create-login-route Nov 23, 2022
@tylerconstance tylerconstance deleted the login-middlend branch November 23, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants