Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ruby 3 #118

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Add support for Ruby 3 #118

merged 5 commits into from
Mar 6, 2023

Conversation

rzane
Copy link
Contributor

@rzane rzane commented Mar 6, 2023

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

TestTrack::AssignmentEventJob expects keyword arguments, but TestTrack::UnsyncedAssignmentsNotifier is passing a hash. This PR splats the hash to make this gem compatible with Ruby 3.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Thanks for contributing to TestTrack!

/domain @Betterment/test_track_core
/platform @Betterment/test_track_core

/no-platform

Appraisals Show resolved Hide resolved
jesseproudman
jesseproudman previously approved these changes Mar 6, 2023
Copy link

@jesseproudman jesseproudman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm

@jesseproudman
Copy link

Do we need to bump the version?

https://github.com/Betterment/test_track_rails_client/blob/master/lib/test_track_rails_client/version.rb

@betterment-policy-bot-production betterment-policy-bot-production bot dismissed jesseproudman’s stale review March 6, 2023 19:56

Dismissed because the approval was invalidated by another commit

@rzane rzane requested a review from jesseproudman March 6, 2023 20:01
jesseproudman
jesseproudman previously approved these changes Mar 6, 2023
Copy link

@jesseproudman jesseproudman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain lgtm

- '2.7'
- '3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding 3.1 while we're here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to, but Rubocop failed with this issue. We need to bump Rubocop, which causes new cops to fail. I'd prefer to do that in a separate PR.

@betterment-policy-bot-production betterment-policy-bot-production bot dismissed jesseproudman’s stale review March 6, 2023 20:30

Dismissed because the approval was invalidated by another commit

Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM!

@rzane rzane requested a review from smudge March 6, 2023 20:34
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM

@smudge smudge merged commit d56e2dc into Betterment:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants