-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ruby 3 #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain lgtm
Do we need to bump the version? |
Dismissed because the approval was invalidated by another commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain lgtm
- '2.7' | ||
- '3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding 3.1 while we're here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to, but Rubocop failed with this issue. We need to bump Rubocop, which causes new cops to fail. I'd prefer to do that in a separate PR.
Dismissed because the approval was invalidated by another commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain LGTM && platform LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain LGTM
Summary
TestTrack::AssignmentEventJob
expects keyword arguments, butTestTrack::UnsyncedAssignmentsNotifier
is passing a hash. This PR splats the hash to make this gem compatible with Ruby 3.Other Information
/domain @Betterment/test_track_core
/platform @Betterment/test_track_core
/no-platform