Add support for Rails 7 (alpha2) #3
Conversation
|
Needs somebody from @samandmoore and @effron to claim domain review Use the shovel operator to claim, e.g.:
|
|
Needs somebody from @samandmoore and @effron to claim domain review Use the shovel operator to claim, e.g.:
|
1 similar comment
|
Needs somebody from @samandmoore and @effron to claim domain review Use the shovel operator to claim, e.g.:
|
| @@ -21,7 +21,7 @@ def start | |||
| def on_exit!; end | |||
|
|
|||
| def interruptable_sleep(seconds) | |||
| IO.select([pipe[0]], nil, nil, seconds) | |||
| pipe[0].wait_readable(seconds) | |||
There was a problem hiding this comment.
A nice little autocorrect: rubocop/rubocop#9061
| @@ -25,7 +25,7 @@ | |||
| it 'autoloads the class of an anonymous struct' do | |||
| expect { | |||
| yaml = "--- !ruby/struct\nn: 1\n" | |||
| object = YAML.load(yaml) | |||
| object = load_with_delayed_visitor(yaml) | |||
There was a problem hiding this comment.
This was just a test bug - we want it to use YAML.load_dj(yaml)
There was a problem hiding this comment.
Looks like the same change is currently proposed upstream too: collectiveidea/delayed_job#1152
| @@ -150,7 +150,7 @@ def <=>(other) | |||
| private | |||
|
|
|||
| def respond_to_missing?(method_name, include_private = false) | |||
| method_name.to_s.end_with?('?') && self.class.names.key?(method_name.to_s[0..-2].to_sym) || super | |||
| (method_name.to_s.end_with?('?') && self.class.names.key?(method_name.to_s[0..-2].to_sym)) || super | |||
There was a problem hiding this comment.
The other linter autocorrect
|
<<domainLGTM! |
|
This PR requires additional review because of new changes Please get another domain review from @effron, or another reviewer with write access if unavailable. |
I just realized that we hadn't cross-referenced this in the other direction! The linter issues are fixed in #3
|
domainlgtm |
|
Approved! 🌟 🔩 🙏 |
/domain @samandmoore @effron
/no-platform
This:
Appraisalentry for7.0.0.alpha2. (I had to specify multiple gems to get the pre-release dependencies to resolve properly.).ruby-versionto2.7, but keeps linting at2.6. (CI will still run against all of 2.6-3.0)ActiveRecord::Base.default_timezone(switches toActiveRecord.default_timezone):classicautoloader is no longer used/supported in Rails 7)