Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set shell to cmd.exe on windows for the jack-in process #2546

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented May 2, 2024

Checking if this makes strange quoting issues on Windows go away.

WIP.

Fixes #

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
    • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tests
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
  • Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
  • Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

Copy link

netlify bot commented May 2, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit 34bb11a
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/6633ec326ba9350008c1d5c8
😎 Deploy Preview https://deploy-preview-2546--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bpringe
Copy link
Member

bpringe commented May 5, 2024

I thought there was a reason we used powershell instead of cmd, but I don't remember and haven't searched Slack or GH for the reason(s). I just wanted to note that here, in case you remember or wanted to search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants