Merge pull request #1433 from BetterThanTomorrow/fix_hover_broken_whe…

…n_cljs_repl_connected_but_no_runtime_exists Use clojure-lsp for hover when provideHover throws exception
BetterThanTomorrow · Dec 12, 2021 · b8f9e03 · b8f9e03
2 parents 6fbcb65 + aed17e7
commit b8f9e03
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 Changes to Calva.
 
 ## [Unreleased]
+- Fix: [Hover broken when repl is connected but cider-nrelp is not present](https://github.com/BetterThanTomorrow/calva/issues/1432)
 
 ## [2.0.229] - 2021-12-12
 - Fix: [Babashka Jack-In REPL doesn't show eval errors](https://github.com/BetterThanTomorrow/calva/issues/1413)

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/lsp/main.ts b/src/lsp/main.ts
@@ -75,7 +75,11 @@ function createClient(clojureLspPath: string): LanguageClient {
                 return null;
             },
             async provideHover(document, position, token, next) {
-                const hover: vscode.Hover = await provideHover(document, position);
+                let hover: vscode.Hover;
+                try {
+                    hover = await provideHover(document, position);
+                } catch (e) {}
+
                 if (hover) {
                     return null;
                 } else {