Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Rails ActionableError #465

Merged
merged 5 commits into from May 14, 2020
Merged

Support for Rails ActionableError #465

merged 5 commits into from May 14, 2020

Commits on May 14, 2020

  1. Add a button the error page if the error is actionable. 

    This adds support for actionable exceptions in Rails. For example, when
a migration needs to be run it'll offer a button that can run
the migrations for the user.
    @connorshea
    connorshea committed May 14, 2020
    Copy the full SHA
    5960d9a View commit details
    Browse the repository at this point in the history

  2. Add specs for actionable errors 

    and include an element around the action forms, and move the use of ActionDispatch out of the template.
    @RobinDaugherty
    RobinDaugherty committed May 14, 2020
    Copy the full SHA
    11427ba View commit details
    Browse the repository at this point in the history

  3. Improve layout of multiline exception messages 

    These look good when output to the console, but double-newlines make the exception harder to read in BE and push any action buttons further down.
    @RobinDaugherty
    RobinDaugherty committed May 14, 2020
    Copy the full SHA
    776a12e View commit details
    Browse the repository at this point in the history

  4. Improve backtrace when a BE template raises error 

    This is purely for BE development.
    @RobinDaugherty
    RobinDaugherty committed May 14, 2020
    Copy the full SHA
    c65b243 View commit details
    Browse the repository at this point in the history

  5. Fix wording of context 

    Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
    @RobinDaugherty @connorshea
    RobinDaugherty and connorshea committed May 14, 2020
    Copy the full SHA
    87cc62d View commit details
    Browse the repository at this point in the history