Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning: __FILE__ in eval may not return location in binding #458

Merged
merged 2 commits into from Apr 18, 2020
Merged

Fix warning: __FILE__ in eval may not return location in binding #458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5284c99
Fix warning: __FILE__ in eval may not return location in binding
yuuu Apr 13, 2020
dbe7ca0
Use Binding#source_location only when available
RobinDaugherty Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/better_errors/raised_exception.rb
View file
Open in desktop
Expand Up @@ -36,8 +36,13 @@ def setup_backtrace

def setup_backtrace_from_bindings
@backtrace = exception.__better_errors_bindings_stack.map { |binding|
file = binding.eval "__FILE__"
line = binding.eval "__LINE__"
if binding.respond_to?(:source_location) # Ruby >= 2.6
file = binding.source_location[0]
line = binding.source_location[1]
else
file = binding.eval "__FILE__"
line = binding.eval "__LINE__"
end
name = binding.frame_description
StackFrame.new(file, line, name, binding)
}
Expand Down