Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various specs that were passing incorrectly #453

Merged
merged 4 commits into from Feb 26, 2020
Merged

Fix various specs that were passing incorrectly #453

merged 4 commits into from Feb 26, 2020

Commits on Feb 26, 2020

  1. Fix falsely passing specs looking for "shortval" 

    They were finding it in the exception backtrace that was being dumped to the HTML.
    @RobinDaugherty
    RobinDaugherty committed Feb 26, 2020
    Copy the full SHA
    22b94ff View commit details
    Browse the repository at this point in the history

  2. Fix incorrect class that was previously missed

    @RobinDaugherty
    RobinDaugherty committed Feb 26, 2020
    Copy the full SHA
    6b0e690 View commit details
    Browse the repository at this point in the history

  3. Use HTML matchers to specifically match content 

    and expose another should-be-failing spec
    @RobinDaugherty
    RobinDaugherty committed Feb 26, 2020
    Copy the full SHA
    c2d20ae View commit details
    Browse the repository at this point in the history

  4. Fix spec looking for failure without valid path in backtrace

    @RobinDaugherty
    RobinDaugherty committed Feb 26, 2020
    Copy the full SHA
    64e65fa View commit details
    Browse the repository at this point in the history