Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping variable inspection by class name #449

Commits on Feb 16, 2020

  1. Allow skipping variable inspection by class name

    This adds a new global setting `BetterErrors.ignored_classes` that will
    skip inspecting the value of local and instance variables of this type.
    The default setting ignores action dispatch request and response
    instances, which are usually not printed anyways due to exceeding the
    limit of `BetterErrors.maximum_variable_inspect_size`, but also avoids
    all the memory allocations and database queries that are triggered by
    calling `#inspect` on variables.
    
    The default setting was chosen to avoid excessive database queries for
    unloaded relations, because both the `ActionDispatch::Request` and the
    `ActionDispatch::Response` objects hold many references to the
    controller instance, causing the same instance variables to be inspected
    over and over again.
    felixbuenemann committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    faa39ec View commit details
    Browse the repository at this point in the history
  2. Fix spec errors with binding of caller

    For some weird reason with binding of caller loaded the inspected value
    for strings is no longer quoted, breaking the specs, so this changes
    the specs back to using all symbols.
    felixbuenemann committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    641da2a View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Revert "Fix spec errors with binding of caller"

    This reverts commit 641da2a.
    RobinDaugherty committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    06a8b9d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4fc5af View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Configuration menu
    Copy the full SHA
    af19911 View commit details
    Browse the repository at this point in the history