Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editor links to work inside an iframe or with CSP that prohibits other protocols #440

Merged
merged 4 commits into from May 14, 2020
Merged

Allow editor links to work inside an iframe or with CSP that prohibits other protocols #440

merged 4 commits into from May 14, 2020

Commits on Apr 23, 2019

  1. adds target=_blank to editor link, to work around CSP 

    restrictions for apps running in a third-party iframe
    @lastobelus
    lastobelus committed Apr 23, 2019
    Copy the full SHA
    5f2cdc6 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Merge 'master' of github.com:BetterErrors/better_errors into lastobel… 

    …us/add-target-to-editor-link
    @RobinDaugherty
    RobinDaugherty committed May 14, 2020
    Copy the full SHA
    c4d3cc1 View commit details
    Browse the repository at this point in the history

  2. Make blank target link optional, add specs

    @RobinDaugherty
    RobinDaugherty committed May 14, 2020
    Copy the full SHA
    eb71f47 View commit details
    Browse the repository at this point in the history

  3. Update README to reflect new environment variable 

    and include EDITOR instructions.
    @RobinDaugherty
    RobinDaugherty committed May 14, 2020
    Copy the full SHA
    7204a5b View commit details
    Browse the repository at this point in the history