Skip to content

Commit

Permalink
Merge pull request #452 from BetterErrors/ruby-2.6-rails-6
Browse files Browse the repository at this point in the history
Ruby 2.6, 2.7; Rails 6.0
  • Loading branch information
RobinDaugherty committed Feb 26, 2020
2 parents c24c87f + 2d7774e commit 593db03
Show file tree
Hide file tree
Showing 6 changed files with 67 additions and 3 deletions.
41 changes: 41 additions & 0 deletions .travis.yml
Expand Up @@ -12,20 +12,25 @@ rvm:
- 2.3.8
- 2.4.9
- 2.5.7
- 2.6.5
- 2.7.0
- ruby-head
gemfile:
- gemfiles/rails42.gemfile
- gemfiles/rails50.gemfile
- gemfiles/rails51.gemfile
- gemfiles/rails52.gemfile
- gemfiles/rails60.gemfile
- gemfiles/rails42_haml.gemfile
- gemfiles/rails50_haml.gemfile
- gemfiles/rails51_haml.gemfile
- gemfiles/rails52_haml.gemfile
- gemfiles/rails60_haml.gemfile
- gemfiles/rails42_boc.gemfile
- gemfiles/rails50_boc.gemfile
- gemfiles/rails51_boc.gemfile
- gemfiles/rails52_boc.gemfile
- gemfiles/rails60_boc.gemfile
- gemfiles/rack.gemfile
- gemfiles/rack_boc.gemfile
- gemfiles/pry09.gemfile
Expand All @@ -38,21 +43,57 @@ matrix:
- gemfile: gemfiles/pry010.gemfile
- gemfile: gemfiles/pry011.gemfile
exclude:
- rvm: 2.2.10
gemfile: gemfiles/rails60.gemfile
- rvm: 2.2.10
gemfile: gemfiles/rails60_boc.gemfile
- rvm: 2.2.10
gemfile: gemfiles/rails60_haml.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails42.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails42_boc.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails42_haml.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails60.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails60_boc.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails60_haml.gemfile
- rvm: 2.4.9
gemfile: gemfiles/rails42.gemfile
- rvm: 2.4.9
gemfile: gemfiles/rails42_boc.gemfile
- rvm: 2.4.9
gemfile: gemfiles/rails42_haml.gemfile
- rvm: 2.4.9
gemfile: gemfiles/rails60.gemfile
- rvm: 2.4.9
gemfile: gemfiles/rails60_boc.gemfile
- rvm: 2.4.9
gemfile: gemfiles/rails60_haml.gemfile
- rvm: 2.5.7
gemfile: gemfiles/rails42.gemfile
- rvm: 2.5.7
gemfile: gemfiles/rails42_boc.gemfile
- rvm: 2.5.7
gemfile: gemfiles/rails42_haml.gemfile
- rvm: 2.6.5
gemfile: gemfiles/rails42.gemfile
- rvm: 2.6.5
gemfile: gemfiles/rails42_boc.gemfile
- rvm: 2.6.5
gemfile: gemfiles/rails42_haml.gemfile
- rvm: 2.7.0
gemfile: gemfiles/rails42.gemfile
- rvm: 2.7.0
gemfile: gemfiles/rails42_boc.gemfile
- rvm: 2.7.0
gemfile: gemfiles/rails42_haml.gemfile
- rvm: ruby-head
gemfile: gemfiles/rails42.gemfile
- rvm: ruby-head
gemfile: gemfiles/rails42_boc.gemfile
- rvm: ruby-head
gemfile: gemfiles/rails42_haml.gemfile
7 changes: 7 additions & 0 deletions gemfiles/rails60.gemfile
@@ -0,0 +1,7 @@
source "https://rubygems.org"

gem "rails", "~> 6.0.0"

gem 'coveralls', require: false

gemspec path: "../"
8 changes: 8 additions & 0 deletions gemfiles/rails60_boc.gemfile
@@ -0,0 +1,8 @@
source "https://rubygems.org"

gem "rails", "~> 6.0.0"
gem "binding_of_caller"

gem 'coveralls', require: false

gemspec path: "../"
8 changes: 8 additions & 0 deletions gemfiles/rails60_haml.gemfile
@@ -0,0 +1,8 @@
source "https://rubygems.org"

gem "rails", "~> 6.0.0"
gem "haml"

gem 'coveralls', require: false

gemspec path: "../"
2 changes: 1 addition & 1 deletion spec/better_errors/stack_frame_spec.rb
Expand Up @@ -97,7 +97,7 @@ module BetterErrors
it "raises on non-NameErrors" do
frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
allow(frame).to receive(:get_local_variable).and_raise(ArgumentError)
expect { frame.local_variable("foo") }.to raise_error
expect { frame.local_variable("foo") }.to raise_error(ArgumentError)
end
end

Expand Down
4 changes: 2 additions & 2 deletions spec/better_errors_spec.rb
Expand Up @@ -41,7 +41,7 @@
[:atom].each do |editor|
it "uses atom:// scheme when set to #{editor.inspect}" do
subject.editor = editor
subject.editor[].should start_with "atom://"
expect(subject.editor[]).to start_with "atom://"
end
end

Expand Down Expand Up @@ -82,7 +82,7 @@
it "uses atom:// scheme when EDITOR=#{editor}" do
ENV["EDITOR"] = editor
subject.editor = subject.default_editor
subject.editor[].should start_with "atom://"
expect(subject.editor[]).to start_with "atom://"
end
end

Expand Down

0 comments on commit 593db03

Please sign in to comment.